forked from openzfs/zfs
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose zpool guids through procfs #68
Merged
anodos325
merged 1 commit into
truenas/zfs-2.1-release
from
add-guid-to-available-pool-info
May 18, 2022
Merged
Expose zpool guids through procfs #68
anodos325
merged 1 commit into
truenas/zfs-2.1-release
from
add-guid-to-available-pool-info
May 18, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anodos325
force-pushed
the
add-guid-to-available-pool-info
branch
from
May 9, 2022 17:33
c95de65
to
aa77c28
Compare
Need to add dealloc. Also appears that pool state not visible on FreeBSD side (possible bug). |
anodos325
force-pushed
the
add-guid-to-available-pool-info
branch
2 times, most recently
from
May 10, 2022 20:38
da5b394
to
657d6e0
Compare
There is a build error in the CI:
Linux is a bit weird about this so in ZFS we use |
Please sign-off the commit when you update so we can see checkstyle pass, too. |
anodos325
force-pushed
the
add-guid-to-available-pool-info
branch
from
May 16, 2022 14:18
657d6e0
to
439ee9c
Compare
ghost
approved these changes
May 16, 2022
There are times when end-users may wish to have a fast and convenient method to get zpool guid without having to use libzfs. This commit exposes the zpool guid via kstats in similar manner to the zpool state. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrew Walker <awalker@ixsystems.com> Closes openzfs#13466
anodos325
force-pushed
the
add-guid-to-available-pool-info
branch
from
May 18, 2022 17:57
439ee9c
to
cf4deb4
Compare
ghost
approved these changes
May 18, 2022
anodos325
added a commit
that referenced
this pull request
May 18, 2022
There are times when end-users may wish to have a fast and convenient method to get zpool guid without having to use libzfs. This commit exposes the zpool guid via kstats in similar manner to the zpool state. Reviewed-by: Alexander Motin <mav@FreeBSD.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Andrew Walker <awalker@ixsystems.com> Closes openzfs#13466
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various places in middleware where we
look up zpool status and guid. Since the guid
is readily available through spa_guid() providing
via procfs is a significant enhancement because
it will reduce allow us to eliminate some frequent
libzfs / py-libzfs calls in favor of just reading
via procfs.
Signed-off-by: Andrew Walker awalker@ixsystems.com
Motivation and Context
Description
How Has This Been Tested?
Types of changes
Checklist:
Signed-off-by
.