Allow Cortex provider to only take a connection object. #1617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:XS
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to d5bf12b in 23 seconds
More details
- Looked at
25lines of code in1files - Skipped
1files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. src/providers/cortex/trulens/providers/cortex/provider.py:109
- Draft comment:
Consider providing more guidance in the error message about what constitutes a valid Snowflake connection object. - Reason this comment was not posted:
Confidence changes required:50%
The PR introduces a check to ensure that thesnowflake_connhas acursormethod, which is a good validation step. However, the error message could be more informative by suggesting what a valid connection object should be.
Workflow ID: wflow_UOOSEy8zFNLQXruF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -229,7 +229,7 @@ | |||
| "\n", | |||
| "snowpark_session = Session.builder.configs(connection_params).create()\n", | |||
| "\n", | |||
| "provider = Cortex(snowpark_session, \"llama3.1-8b\")\n", | |||
| "provider = Cortex(snowpark_session.connection, \"llama3.1-8b\")\n", | |||
There was a problem hiding this comment.
we used to only require the snowpark_session here. why did we change this?
There was a problem hiding this comment.
We always needed connection for providers.
sfc-gh-jreini
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Cortex provider will not accept a session object, and we have seen this as an accidental thing many users are doing.
Type of change
not work as expected)
Important
Ensure
Cortexonly accepts a Snowflake connection object by checking for acursormethod inprovider.py.Cortex.__init__, added a check to ensuresnowflake_connhas acursormethod, raisingValueErrorif not.snowflake_connto clarify it should not be a session object.This description was created by
for d5bf12b. It will automatically update as commits are pushed.