Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relax snowflake-ml-python version #1664

Merged
merged 3 commits into from
Nov 26, 2024
Merged

relax snowflake-ml-python version #1664

merged 3 commits into from
Nov 26, 2024

Conversation

sfc-gh-chu
Copy link
Contributor

@sfc-gh-chu sfc-gh-chu commented Nov 22, 2024

Description

snowflake-ml-python>=1.7.1 doesn't support python 3.8, which conflicts with trulens

Other details good to know for developers

Please include any other details of this change useful for TruLens developers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to
    not work as expected)
  • New Tests
  • This change includes re-generated golden test results
  • This change requires a documentation update

Important

Relax snowflake-ml-python version from ^1.7.1 to ^1.4 in pyproject.toml.

  • Dependencies:
    • Relax snowflake-ml-python version from ^1.7.1 to ^1.4 in pyproject.toml.

This description was created by Ellipsis for a1e09cc. It will automatically update as commits are pushed.

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Nov 22, 2024
Copy link
Contributor

@sfc-gh-dhuang sfc-gh-dhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do "^1.6.4" (the latest version that still supports Python 3.8) to ensure Cortex provider still works?

for context, snowflake-ml-python >= 1.7.1 is required for REST-basedComplete, and earlier versions, especially older than 1.5x, have not been tested for the python Complete api (not even sql based)

Copy link
Contributor

@sfc-gh-dhuang sfc-gh-dhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for fixing this

@sfc-gh-chu sfc-gh-chu merged commit 14c5aa8 into main Nov 26, 2024
9 of 10 checks passed
@sfc-gh-chu sfc-gh-chu deleted the corey/lock-fix branch November 26, 2024 17:19
@sfc-gh-chu sfc-gh-chu mentioned this pull request Dec 3, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants