Fix Cortex provider for tests. #1666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:M
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| ) | ||
| ): | ||
| if ( | ||
| hasattr(self, "DEFAULT_SNOWPARK_SESSION") |
There was a problem hiding this comment.
The hasattr check for DEFAULT_SNOWPARK_SESSION is redundant since it's a class variable and will always exist. Directly check if self.DEFAULT_SNOWPARK_SESSION is not None. This applies to line 110.
Suggested change
| hasattr(self, "DEFAULT_SNOWPARK_SESSION") | |
| self.DEFAULT_SNOWPARK_SESSION is not None |
| @@ -100,12 +103,30 @@ def __init__( | |||
| *args, **kwargs | |||
| ) | |||
|
|
|||
| self_kwargs["snowpark_session"] = ( | |||
| if snowpark_session is None or pyschema_utils.is_noserio( | |||
There was a problem hiding this comment.
ah thanks for fixing this - I missed checking explicitly the case where session exists but non-serializable
sfc-gh-dhuang
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix Cortex provider for tests.
Other details good to know for developers
Type of change
not work as expected)
Important
Fixes Cortex provider's Snowflake session handling by introducing a default session and updating test setup.
DEFAULT_SNOWPARK_SESSIONtoCortexclass inprovider.pyfor default session handling.DEFAULT_SNOWPARK_SESSIONif no session is provided or ifpyschema_utils.is_noserio()returns true.ValueErrorif session inference fails, suggesting settingDEFAULT_SNOWPARK_SESSION.Cortex.DEFAULT_SNOWPARK_SESSIONinsetUp()ofSnowflakeTestCaseinsnowflake_test_case.pyto ensure consistent session usage across tests.test-snowflaketarget for running Snowflake-specific tests.This description was created by
for 0e17bc1. It will automatically update as commits are pushed.