Move main_input, main_output, and _extract_content out of app.py
#1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:L
| Args: | ||
| func: The main function whose main output we are guessing. | ||
|
|
||
| sig: The signature of the above function. |
There was a problem hiding this comment.
I take it the sig and bindings was just copied artifacts from main_input?
There was a problem hiding this comment.
@sfc-gh-dkurokawa this was copied from the main_output function in app.py - https://github.com/truera/trulens/pull/1706/files#diff-a0cb43176f26ebca0d9559a62aa78222738e50a70ac8f79bc3c39f9b12c724c8L839-L841
tests/unit/static/golden/test_otel_instrument__test_instrument_decorator.csv
Outdated
Show resolved
Hide resolved
sfc-gh-gtokernliang
force-pushed
the
garett/moving-things-out
branch
from
a52872c to
788f945
Compare
sfc-gh-dkurokawa
approved these changes
Jan 9, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved
main_input,main_output, and_extract_contentout of app.py for easier reuseOther details good to know for developers
N/A
Type of change
not work as expected)
Important
Refactored
main_input,main_output, and_extract_contentfunctions tosignature.pyand added tests intest_signature_utils.py.main_input,main_output, and_extract_contentfromapp.pytosignature.pyfor better reusability.test_signature_utils.pyto testmain_inputandmain_outputfunctions.api.trulens.3.11.yamlto reflect changes in function locations.This description was created by
for 5b6c7be. It will automatically update as commits are pushed.