Don't create event tables unless TRULENS_OTEL_TRACING
env variable is set.
#1724
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Don't create event tables unless
TRULENS_OTEL_TRACING
env variable is set.Currently things are broken for dialects that don't handle JSON which include Snowflake and possibly other stuff.
Other details good to know for developers
Type of change
not work as expected)
Important
Event tables are conditionally created based on
TRULENS_OTEL_TRACING
environment variable to fix JSON dialect issues.TRULENS_OTEL_TRACING
environment variable is set to "1" or "true" in10_create_event_table.py
.TRULENS_OTEL_TRACING
to "1" insetUpClass
ofTestOtelInstrument
intest_otel_instrument.py
.model_fields
havingitems
attribute inget_class_members
inutils.py
to handle Pydantic models.This description was created by for d420a17. It will automatically update as commits are pushed.