update

trufflesecurity · Oct 11, 2024 · 5897fda · 5897fda
1 parent 5c8357e
commit 5897fda
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/pkg/handlers/handlers_test.go b/pkg/handlers/handlers_test.go
@@ -468,15 +468,17 @@ func TestHandleZipCommandStdoutPipe(t *testing.T) {
 		assert.NoError(t, err)
 	}()
 
-	err = cmd.Wait()
-	assert.NoError(t, err)
-
 	wantCount := 8
 	count := 0
 	for range chunkCh {
 		count++
 	}
 
+	// cmd.Wait() should be called after all the reading from the pipe is done.
+	// https://cs.opensource.google/go/go/+/refs/tags/go1.23.2:src/os/exec/exec.go;l=1051-1053
+	err = cmd.Wait()
+	assert.NoError(t, err)
+
 	assert.Equal(t, wantCount, count)
 }