[Analyzer] Test and generated permissions for HuggingFace, Square & Stripe #3294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abmussani
changed the title
mcastorina
approved these changes
Sep 18, 2024
Comment on lines
1
to
7
| permissions: | ||
| - BANK_ACCOUNTS_READ | ||
| - APPOINTMENTS_WRITE | ||
| - APPOINTMENTS_ALL_WRITE | ||
| - APPOINTMENTS_READ | ||
| - APPOINTMENTS_ALL_READ | ||
| - APPOINTMENTS_BUSINESS_SETTINGS_READ |
There was a problem hiding this comment.
Is there a reason why these are all capitalized? I don't recall any other analyzer doing that.
There was a problem hiding this comment.
I think I copied it from somewhere. You are right, all of our analyzers have permissions in small caps. Let me change this one in the name of consistency.
There was a problem hiding this comment.
@mcastorina updated the permissions with small caps for consistency.
mcastorina
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR includes test and generated enumerated permissions for HuggingFace, Square & Stripe Analyzers.
Checklist:
make test-community)?make lintthis requires golangci-lint)?