Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[analyze] Add client filter to detect successful unsafe HTTP requests #3305

Merged
merged 3 commits into from
Sep 18, 2024
Merged

[analyze] Add client filter to detect successful unsafe HTTP requests #3305

merged 3 commits into from
Sep 18, 2024

Conversation

mcastorina
Copy link
Collaborator

Description:

  • Moves existing analyzer client code to a new file
  • Adds another RoundTripper implementation to return an error if an unsafe HTTP request returns a successful status code

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@mcastorina mcastorina requested a review from a team as a code owner September 17, 2024 19:04
@mcastorina
Copy link
Collaborator Author

Will probably be easier to review ignoring the first "move code to new file" commit.

https://github.com/trufflesecurity/trufflehog/pull/3305/files/b18a359d6f8605f25a1b90fae5e4c2e89b94f5f0..460ac430b59cf6dd45d9cb1d4fb2321a9668f9e9

@mcastorina mcastorina merged commit b2da2a6 into main Sep 18, 2024
12 checks passed
@mcastorina mcastorina deleted the analyze-detect-unsafe-successes-2 branch September 18, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bill-rich bill-rich bill-rich approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcastorina @bill-rich