[fix] Move detector initialization to DefaultDetectors function #3341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| customizer.UseCloudEndpoint(true) | ||
| if cfg.CustomVerifiersOnly && len(urls) > 0 { | ||
| customizer.UseCloudEndpoint(false) | ||
| customizer.UseFoundEndpoints(false) |
There was a problem hiding this comment.
Are we sure we want found endpoints off here?
There was a problem hiding this comment.
That's a good question. We currently don't have controls to separate the configured cloud endpoint vs found endpoints though, so I defaulted to tying them together.
If a user specifies --custom-verifiers-only imo that means "only use the endpoints I specifically configured"
dustin-decker
approved these changes
Sep 26, 2024
kashifkhan0771
pushed a commit
to kashifkhan0771/trufflehog
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Moves initialization out on
NewEngineand intoDefaultDetectorsso all calls to it will be given a list of detectors that are ready to use.Checklist:
make test-community)?make lintthis requires golangci-lint)?