feat: added check for valid git commit and warning message #3413
Conversation
main.go
Outdated
| if len(commit) != 40 { | ||
| return false | ||
| } |
There was a problem hiding this comment.
I don't believe it's necessary to provide the full SHA.
Git is smart enough to figure out what commit you’re referring to if you provide the first few characters of the SHA-1 hash, as long as that partial hash is at least four characters long and unambiguous; that is, no other object in the object database can have a hash that begins with the same prefix.
https://git-scm.com/book/en/v2/Git-Tools-Revision-Selection#_short_sha_1
There was a problem hiding this comment.
Can you check now, I have fixed the issue, also how to link the issue with the PR? I can't see the option to do so
There was a problem hiding this comment.
Doing basic validation is helpful.
However, I think the only way to properly satisfy #3394 is to dispatch a command to Git. (e.g., https://stackoverflow.com/questions/18515488/how-to-check-if-the-commit-exists-in-a-git-repository-by-its-sha-1)
There was a problem hiding this comment.
Yeah, you are right, I have fixed by dispatching this command from the function.
|
Thanks @sahil9001, sorry for the delayed review here. |
Description:
This PR addresses this issue #3394 , wherein we check the validity of git commit and throw the invalid commit message if commit doesn't match the GitHub SHA standard.
Checklist:
make test-community)?make lintthis requires golangci-lint)?