[detector] feat: added rootly detector #3414
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
reviewed
Oct 15, 2024
pkg/detectors/rootly/rootly.go
Outdated
| // Keywords are used for efficiently pre-filtering chunks. | ||
| // Use identifiers in the secret preferably, or the provider name. | ||
| func (s Scanner) Keywords() []string { | ||
| return []string{"rootly"} |
There was a problem hiding this comment.
Suggested change
| return []string{"rootly"} | |
| return []string{"rootly_"} |
Comment on lines
+40
to
+43
| if len(match) != 1 { | ||
| continue | ||
| } | ||
| resMatch := strings.TrimSpace(match[0]) |
There was a problem hiding this comment.
Just curious, how did you generate this? This logic, present in some detectors, is old and doesn't conform to current best practices.
The "alchemy" detector seems to be the template that is good to follow.
https://github.com/trufflesecurity/trufflehog/blob/main/hack/docs/Adding_Detectors_external.md
https://github.com/trufflesecurity/trufflehog/blob/aa17b8eba486bbdf19bc77aedb3c56f9cb00e1ac/pkg/detectors/alchemy/alchemy.go
There was a problem hiding this comment.
I actually took the reference from alienvault and tried to follow that, I will update this.
There was a problem hiding this comment.
@rgmz Can you check again?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Explain the purpose of the PR.
Relates to #3396
I have verified the tests for rootly by trying it with original working API key and here are the results.
Detector Unit Tests:
Checklist:
make test-community)?make lintthis requires golangci-lint)?