Added image4 scanner #345
Merged
Added image4 scanner #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkg/detectors/image4/image4.go
Outdated
| client = common.SaneHttpClient() | ||
|
|
||
| //Make sure that your group is surrounded in boundry characters such as below to reduce false positives | ||
| keyPat = regexp.MustCompile(detectors.PrefixRegex([]string{"image4"}) + `\b([0-9a-zA-Z]{22}\==)`) |
There was a problem hiding this comment.
This looks like a base64 encoded token. The == at the end is padding, and might not always be like that.
This would be more correct:
\b([0-9a-zA-Z]{22}[0-9a-zA-Z\=]{2})
There was a problem hiding this comment.
I just commited the changes in regex
bill-rich
pushed a commit
that referenced
this pull request
May 2, 2022
* added new protos * added image4 scanner * Updated the regex
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.