fix: fixed verification logic & endpoint for AyrShare #3452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please don't ping me for every change that you make. |
Sure, sorry for that. |
|
I thought you were an active contributor, so added you, else I don't know who is managing Hacktoberfest here. |
I am, but I'm just a random guy. |
2 tasks
sahil9001
changed the title
sahil9001
changed the title
kashifkhan0771
requested changes
Oct 18, 2024
| @@ -48,7 +49,7 @@ func (s Scanner) FromData(ctx context.Context, verify bool, data []byte) (result | |||
| } | |||
|
|
|||
| if verify { | |||
| req, err := http.NewRequestWithContext(ctx, "GET", "https://app.ayrshare.com/api/analytics/links", nil) | |||
| req, err := http.NewRequestWithContext(ctx, "GET", "https://app.ayrshare.com/api/user", nil) | |||
There was a problem hiding this comment.
The /user API returns useful information, such as the user's email, which can be included in the extra data.
I also recommend reviewing the status code documentation to handle responses appropriately.
kashifkhan0771
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Thank you @sahil9001 for fixing this detector regex. Changes LGTM!
|
First official hacktoberfest-2024 merged PR 🥂. Nice work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Fixes #3451 , tests screenshots:
Checklist:
make test-community)?make lintthis requires golangci-lint)?