[bug] - Correct Line Number Calculation #3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
force-pushed
the
bug-fix-line-number-reporting
branch
from
7e6044e
to
2b6ba28
Compare
rosecodym
reviewed
Nov 4, 2024
There was a problem hiding this comment.
Thanks for this (and for the test!) But the last time we fixed an "obvious" off-by-one line number error, a bunch of people complained about a breaking change, and we reverted it. Will those complaints happen again here? And if it does, do we have a plan for it? (This is largely a @zricethezav question I think)
Who can say. Ahrav wrote a test here that looks solid to me. If it breaks something, we'll find out about it quickly and revert it. |
zricethezav
approved these changes
Nov 5, 2024
dustin-decker
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the
fragmentStartvalue to use 1-based indexing, aligning it with file numbering. This change resolves the off-by-one line number issue that occurred when theLinevalue was not specified in thesource_metadataproto.Checklist:
make test-community)?make lintthis requires golangci-lint)?