Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log false positive result as string #3582

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Log false positive result as string #3582

merged 1 commit into from
Nov 10, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Nov 10, 2024

Description:

This is a follow-up to #3579. The result needs to be string and not []byte, otherwise it gets logged as base64.

"result": "bXlQYXNzd29yZA=="

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner November 10, 2024 15:11
@ahrav ahrav merged commit b715613 into trufflesecurity:main Nov 10, 2024
13 checks passed
@rgmz rgmz deleted the feat/log-fps-string branch November 10, 2024 18:30
@blsaccess blsaccess mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @ahrav