Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase level for verbose log #3589

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Nov 12, 2024

Description:

This bumps skipping file: extension is ignored from --debug to --trace as it can be quite noisy.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner November 12, 2024 00:53
@ahrav
Copy link
Collaborator

ahrav commented Nov 12, 2024

Description:

This bumps skipping file: extension is ignored from --debug to --trace as it can be quite noisy.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

I see you had a change of heart 😉
#3383 (comment)

EDIT: I have no idea why i hit "Quote reply" instead of leaving a regular comment. 🤦

@rgmz
Copy link
Contributor Author

rgmz commented Nov 12, 2024

Lol, I am torn on it. Maybe it's fine, idk.

I think part of the problem is that you can't specify a level so it's all or nothing. There's a lot of stuff in 3 & 4 that I'd like to see without 5.

@ahrav
Copy link
Collaborator

ahrav commented Nov 12, 2024

I think part of the problem is that you can't specify a level

+1000 to this. I’ve always found the way we map log levels to CLI flags a bit puzzling. I don’t have strong opinions on what level this should be, but if we stick with level 3, we should update the contributing.md here 🤣

Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving even though it doesn't actually have any effect. 😅

@dustin-decker
Copy link
Contributor

I think part of the problem is that you can't specify a level

+1000 to this. I’ve always found the way we map log levels to CLI flags a bit puzzling. I don’t have strong opinions on what level this should be, but if we stick with level 3, we should update the contributing.md here 🤣

Those CLI flags predated our leveled logger

@dustin-decker dustin-decker merged commit 6130400 into trufflesecurity:main Nov 12, 2024
13 checks passed
@rgmz rgmz deleted the chore/verbose-log branch November 12, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants