[chore] Log non-fatal errors encountered during a scan #3612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecodym
approved these changes
Nov 18, 2024
Comment on lines
+887
to
+890
| errMsgs := make([]string, len(errs)) | ||
| for i := 0; i < len(errs); i++ { | ||
| errMsgs[i] = errs[i].Error() | ||
| } |
There was a problem hiding this comment.
Why did you stringify these yourself in a new slice instead of just logging them directly?
There was a problem hiding this comment.
I thought it looked better stringified:
{"errors": ["error chunking dir \"/tmp/fake-dir/\": repository does not exist"]}
vs
{"errors": [{"error": "error chunking dir \"/tmp/fake-dir/\": repository does not exist"}]}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Non-fatal errors produced by a source during enumeration or chunking are recorded in the report, but we don't do anything with them. This PR logs them after the scan completes.
Checklist:
make test-community)?make lintthis requires golangci-lint)?