Add log.ToLogger and log.ToSlogger helper functions #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
approved these changes
Nov 19, 2024
| @@ -184,6 +186,16 @@ func WithGlobalRedaction() func(*sinkConfig) { | |||
| } | |||
| } | |||
|
|
|||
| // ToLogger converts the logr.Logger into a legacy *log.Logger. | |||
| func ToLogger(l logr.Logger) *log.Logger { | |||
| return slog.NewLogLogger(logr.ToSlogHandler(l), slog.LevelInfo) | |||
There was a problem hiding this comment.
question: I might be missing something or there are too many logs/slogs combos 🤣 , but should this be log. or should the comment be updated.
There was a problem hiding this comment.
It compiles so it's correct, lol! It's doing logr.Logger -> slog.Handler -> *log.Logger.
The slog package has a function to "bridge" slog to the old log lib. See slog.NewLogLogger.
The logger acts as a bridge from the older log API to newer structured logging handlers.
zricethezav
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds helper functions for converting our logger into other forms of stdlib logging.
Checklist:
make test-community)?make lintthis requires golangci-lint)?