Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed scrapingAnt detector #3736

Merged
merged 1 commit into from
Dec 9, 2024
Merged

fixed scrapingAnt detector #3736

merged 1 commit into from
Dec 9, 2024

Conversation

kashifkhan0771
Copy link
Contributor

Description:

Fixed the scrapingAnt detector.
The API use x-api-key in query parameter not in the header.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested a review from a team as a code owner December 6, 2024 12:47
ahrav
ahrav approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's wild, I can't believe they need the API key in the url. 🤯

@ahrav ahrav merged commit fb9f0a5 into trufflesecurity:main Dec 9, 2024
13 checks passed
@kashifkhan0771 kashifkhan0771 deleted the fix/scrapingant-detector branch December 10, 2024 03:14
@blsaccess blsaccess mentioned this pull request Dec 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashifkhan0771 @ahrav