Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled blocknative detector #3804

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Disabled blocknative detector #3804

merged 2 commits into from
Dec 20, 2024

Conversation

kashifkhan0771
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 commented Dec 19, 2024 •
edited
Loading

Description:

This PR disables the blocknative detector as their API is returning 200OK always and resulting in false-positives.
This resolves issue #3721

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested review from a team as code owners December 19, 2024 16:58
@kashifkhan0771 kashifkhan0771 merged commit 2b43d34 into trufflesecurity:main Dec 20, 2024
13 checks passed
@kashifkhan0771 kashifkhan0771 deleted the disable/blocknative-detector branch December 20, 2024 07:20
@blsaccess blsaccess mentioned this pull request Dec 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abmussani abmussani abmussani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashifkhan0771 @abmussani