Added flowdash scanner #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrav
approved these changes
Apr 21, 2022
pkg/detectors/flowdash/flowdash.go
Outdated
| } | ||
|
|
||
| if verify { | ||
| req, err := http.NewRequestWithContext(ctx, "GET", "https://app.flowdash.com/api/v1/workflows", nil) |
There was a problem hiding this comment.
nit: maybe use https://app.flowdash.com/api/v1/workspace as the endpoint vs workflows? The response object for workspace will generally always be a single item whereas for workflows i'm not certain on the resulting response objects size. Potentially a lot bigger if they are a large org and even moreso if their API doesn't support pagination. This way we lower the call's overhead and maybe reducing latency.
There was a problem hiding this comment.
Great! I just pushed the changes. Thanks @ahrav!
bill-rich
pushed a commit
that referenced
this pull request
May 2, 2022
* added new protos * added new detectors * added flowdash scanner * updated the endpoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.