Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keep first line number for each chunk #520

Merged
merged 1 commit into from
May 4, 2022
Merged

Keep first line number for each chunk #520

merged 1 commit into from
May 4, 2022

Conversation

bill-rich
Copy link
Collaborator

Store the first line of a fragment for each chunk so that each result can use that starting line to determine the actual line number.

Fixes #435

@bill-rich bill-rich requested a review from a team May 4, 2022 03:48
dustin-decker
dustin-decker approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after checking against the repository in the bug report

@bill-rich bill-rich merged commit 62bb3c5 into main May 4, 2022
@bill-rich bill-rich deleted the line_numbers_with_multiple_results branch May 4, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker dustin-decker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong details in Trufflehog Output
2 participants
@bill-rich @dustin-decker