Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[THOG-336] Use the string version of the Detector Type in json output. #538

Merged
merged 5 commits into from
May 13, 2022
Merged

[THOG-336] Use the string version of the Detector Type in json output. #538

merged 5 commits into from
May 13, 2022

Conversation

ahrav
Copy link
Collaborator

@ahrav ahrav commented May 13, 2022

Instead of printing the DetectorType Enum use the string. This makes the output message a lot easier to analyze to determine which detector found a secret.
#385

dustin-decker
dustin-decker requested changes May 13, 2022
View reviewed changes
Copy link
Contributor

@dustin-decker dustin-decker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably preserve DetectorType and add DetectorName as the string to avoid making a breaking change

@dustin-decker dustin-decker merged commit 928b3b4 into main May 13, 2022
@dustin-decker dustin-decker deleted the THOG-336-Use-String-Detector-Value branch May 13, 2022 16:02
@dustin-decker dustin-decker mentioned this pull request May 13, 2022
Closed
@ahrav ahrav changed the title [THOG-336] Use the string version of the Detector Type. [THOG-336] Use the string version of the Detector Type in json output. May 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dustin-decker dustin-decker Awaiting requested review from dustin-decker

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrav @dustin-decker