-
Notifications
You must be signed in to change notification settings - Fork 806
Test components #1137
base: develop
Are you sure you want to change the base?
Test components #1137
Conversation
Thanks! Will get this reviewed. |
@@ -0,0 +1,10 @@ | |||
const babelOptions = { | |||
presets: ["env", "stage-0", "react"], | |||
plugins: [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What are these for? I ran your tests locally without any plugins and it still worked.
I suggest removing this if they are not needed.
@@ -0,0 +1,10 @@ | |||
const babelOptions = { | |||
presets: ["env", "stage-0", "react"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stage-0 seems like it's a bit much to me, do you know what JS feature exactly this is adding that the tests need?
I did try running without stage-0 and it didn't work.
At least one of the plugin is for async / await, the other I dont know.
As for stage-0, no I dont know exactly which features are needed.
In the future we could totally get rid of stage-0 by upgrading to babel 7.x and add missing plugins (for babel7.x, stage-0 is deprecated, there are only plugins available).
Generally speaking I would like to have the same babel configuration that for the code of the components we are testing.
|
@jklepatch Yea I see what you mean, However, the tests you wrote don't utilize the plugins at all, so I still think it would help to simplify this PR by removing them. In the future, when the tests require the use of one of the plugins we can put it back in. |
e2089a6
to
d685a7b
Compare
#1133