Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Use async/await for callbacks in test files #307

Closed
29 of 37 tasks
ccowell opened this issue Feb 15, 2019 · 0 comments
Closed
29 of 37 tasks

Use async/await for callbacks in test files #307

ccowell opened this issue Feb 15, 2019 · 0 comments

Comments

@ccowell
Copy link
Contributor

ccowell commented Feb 15, 2019

This issue addresses the need to convert callbacks/Promises into async/await pattern as a refactoring step. The PRs that reference this issue may also include other changes such as updated library paths, variable names/declarations or swapping out arrow functions, etc. The goal is to make the review process as easy as possible.

Note: Will revisit refactoring send functionality requiring a callback. #351

Files reviewed or ready for review

  • accounts.js MERGED
  • bad_input.js
  • blockTags.js
  • call.js MERGED
  • customGasLimit.js MERGED
  • customGasPrice.js MERGED
  • debug.js MERGED
  • enable_constantinople_hardfork.js MERGED
  • ethereum.js MERGED
  • ethers.js MERGED
  • events.js
  • forking.js
  • forkingasprovider.js
  • forking_deploy_after_fork.js
  • gas.js MERGED
  • gasLimit.js MERGED
  • gasPrice.js MERGED
  • hex.js
  • interval_mining.js
  • keepAliveTimeout.js MERGED
  • mining.js
  • persistence.js
  • public-exports.js MERGED
  • requests.js
  • runtime_errors.js
  • server.js MERGED
  • snapshotting.js
  • stability.js
  • swarm.js MERGED
  • time_adjust.js
  • transaction.js
  • transaction_ordering.js
  • transaction_rejection.js
  • undefined.js
  • unlimited_contract_size.js
  • vm.js
  • whisper.js MERGED
@ccowell ccowell self-assigned this Feb 15, 2019
ccowell added a commit that referenced this issue Feb 19, 2019
Refactored debug.js
Added an extra send function to rpc.js for compatiblity and updated affected legacy tests
ccowell added a commit that referenced this issue Feb 19, 2019
Note:
Moved noLeadingZeros into security/lib folder
ccowell added a commit that referenced this issue Feb 19, 2019
ccowell added a commit that referenced this issue Feb 19, 2019
ccowell added a commit that referenced this issue Feb 19, 2019
ccowell added a commit that referenced this issue Feb 19, 2019
Note:
- Moved `testTimeout` into `events/lib`
ccowell added a commit that referenced this issue Feb 19, 2019
Note:
- No async/await patterns were added
- Updated filename, file location, lib references and other minor changes
ccowell added a commit that referenced this issue Feb 19, 2019
Note:
- Updated lib reference
ccowell added a commit that referenced this issue Feb 19, 2019
Note:
- Moved file to a subfolder
ccowell added a commit that referenced this issue Feb 19, 2019
ccowell added a commit that referenced this issue Feb 19, 2019
ccowell added a commit that referenced this issue Feb 20, 2019
ccowell added a commit that referenced this issue Feb 21, 2019
ccowell added a commit that referenced this issue Feb 22, 2019
davidmurdoch pushed a commit that referenced this issue Mar 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants