This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 684
Use async/await for callbacks in test files #307
Labels
Comments
ccowell
added a commit
that referenced
this issue
Feb 19, 2019
ccowell
added a commit
that referenced
this issue
Feb 19, 2019
ccowell
added a commit
that referenced
this issue
Feb 19, 2019
Note: - Moved `testTimeout` into `events/lib`
ccowell
added a commit
that referenced
this issue
Feb 19, 2019
Note: - No async/await patterns were added - Updated filename, file location, lib references and other minor changes
ccowell
added a commit
that referenced
this issue
Feb 20, 2019
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This issue addresses the need to convert callbacks/Promises into async/await pattern as a refactoring step. The PRs that reference this issue may also include other changes such as updated library paths, variable names/declarations or swapping out arrow functions, etc. The goal is to make the review process as easy as possible.
Note: Will revisit refactoring
send
functionality requiring a callback. #351Files reviewed or ready for review
forking_deploy_after_fork.jsThe text was updated successfully, but these errors were encountered: