This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
perf: improve performance of the persistent cache used in forking #2811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffsmale90
force-pushed
the
improve_persistent_cache_get_performance
branch
2 times, most recently
from
9d28c3e
to
ca31b75
Compare
jeffsmale90
changed the title
jeffsmale90
changed the title
- Make 'lt' argument more specific in order to retrieve less entries - Convert block hash to Buffer type immediately on initiatisation (rather than every time we get / put an entry)
jeffsmale90
force-pushed
the
improve_persistent_cache_get_performance
branch
from
ca31b75
to
0a4947b
Compare
|
Running the convex-shutdown-simulation, I'm seeing a 3.5% performance improvement (~870ms) with this change. |
davidmurdoch
approved these changes
Apr 7, 2022
MicaiahReid
pushed a commit
to domob1812/ganache
that referenced
this pull request
Apr 20, 2022
…ufflesuite#2811) No change in behaviour, but makes working with local forks ever so slightly faster.
tenthirtyone
added a commit
that referenced
this pull request
May 5, 2022
* feat: create version-check package * attempt CI fix * fix * Add some missing colors * small refactor * chore(release): publish v7.0.4 ganache@7.0.4 * perf: improve performance of the persistent cache used in forking (#2811) No change in behaviour, but makes working with local forks ever so slightly faster. * chore: remove outdated warning about EIP-1193 fork providers (#2856) closes #2558 * ci: automated release improvements (#2892) * add vX.x.x tag on release * merge master into develop after successful publish * add action to import TrufBot GPG keys for signed commits * squashme - VersionChecker class plated * squashme stub unit tests * feat: create version-check package * attempt CI fix * fix * Add some missing colors * small refactor * squashme unit test start * squashme semver unit tests * squashme fetch wired up * squashme cleaning up a bit * comment out failing semvers * log unit tests * test e2e, add semver package * snipe errant branches * replace init race condition test with sinon spy * fail silently if server unavailable * final preflight before squash and PR * add constructor and config types * disable if in CI * logVersionMessage for --version * remove the disable in CI... because it actually disables in CI... for everything ::facepalm:: * add to ganache, fix versionMesage string for yargs * add version-check back to cli * handle invalid semver * only setLatestSemver if valid semver * clean up my testing changes that were accidentally committed * bump @ganache/colors, shrinkwrap * add clean and validate function, reduce function checks * disable if currentVersion is not valid semver * validate and clean semver at entry * sparse config test * alpha and beta, v strings * Update src/packages/version-check/index.ts Co-authored-by: Micaiah Reid <micaiahreid@gmail.com> * move banner to end of CLI, before starting message * fix session being held open after stopping in vs code * remove scope from package.json * fix startGanache banner log location. Add to README * fix req.end holding a connection open that prevents starting multiple instances Co-authored-by: Robot <robot@trufflesuite.com> Co-authored-by: jeffsmale90 <6363749+jeffsmale90@users.noreply.github.com> Co-authored-by: g. nicholas d'andrea <gnidan@users.noreply.github.com> Co-authored-by: Micaiah Reid <micaiahreid@gmail.com> Co-authored-by: tenthirtyone <alexsherbuck@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the level get stream's 'lt' argument more specific in order to retrieve fewer entries and convert block hash to Buffer type immediately on initialization (rather than every time we get / put an entry).