This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: properly handle 'estimate' for defaultTransactionGasLimit option on the CLI
#3233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tenthirtyone
requested review from
davidmurdoch,
MicaiahReid and
jeffsmale90
and removed request for
davidmurdoch
MicaiahReid
suggested changes
Jun 17, 2022
There was a problem hiding this comment.
Tested, looks good! In the description, could you updated it to say "Fixes: #2398" rather than "Related"? This will trigger GitHub to close the issue once merged.
MicaiahReid
approved these changes
Jun 22, 2022
davidmurdoch
approved these changes
Jun 22, 2022
davidmurdoch
changed the title
defaultTransactionGasLimit option on the CLI
…iCoerce minerFunction
davidmurdoch
force-pushed
the
bug/cli-defaultTransactionGasLimit-estimate
branch
from
d65683c
to
ab1d9f4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
estimatewas causing an error when the miner options would attempt to cast the string to BigInt.This change adds the
estimateOrToBigIntOrStringfunction to Ethereum's miner options to intercept and handle theestimateoption on the cli.Fixes #2398