Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix: reduce bundle size and check size in CI #3275

Merged
merged 8 commits into from
Jun 24, 2022
Merged

Conversation

davidmurdoch
Copy link
Member

@davidmurdoch davidmurdoch commented Jun 23, 2022

jsDelivr has an unpacked bundle size limit of 100MB, which we recently exceeded, breaking our CDN recommendation in our README.md.

This change reduces the bundle size to under 100MB and also adds a check to our pr.yml CI Action that will fail if the new bundle size is greater than 100 MB.

@davidmurdoch davidmurdoch changed the title ci: check bundle size in CI ci: reduce bundle size and check size in CI Jun 23, 2022
@davidmurdoch davidmurdoch changed the title ci: reduce bundle size and check size in CI fix: reduce bundle size and check size in CI Jun 23, 2022
Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it still possible for the bundle to be larger than the threshold, and what happens, Ganache process wise, if too large?

.github/workflows/pr.yml Outdated Show resolved Hide resolved
Copy link
Member

@cds-amal cds-amal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, bash wise :)

@davidmurdoch davidmurdoch merged commit 783ae63 into develop Jun 24, 2022
@davidmurdoch davidmurdoch deleted the check-bundle-size branch June 24, 2022 14:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants