This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix: evm_setTime
doesn't work correctly with miner.timestampIncrement
#3506
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
miner.timestampIncrement
, callingevm_setTime
can result in unexpected values, and potentially with an error being thrown.This is because the
timeAdjustment
is applied to the previous blocktime, so this offset is applied for every block that is mined.With the following example, the initial block is mined correctly, as is the first block after setting the time, but subsequent blocks will have a descending block time, until the value becomes negative.
Fixes: #3330