Fix for trufflesuite/ganache-cli#354 #57
Conversation
|
@benjamincburns - ok - updated per your direction. |
|
hrm - travis failed, but i think the tests all pass with both of the latest commits? |
|
I’ll have a look today. If it just needs a quick fix, I’ll handle it,
provided you ticked the box that lets project members push changes. Thanks
for your contribution!
…On Wed, Jan 24, 2018 at 8:49 AM yarrumretep ***@***.***> wrote:
hrm - travis failed, but i think the tests all pass with both of the
latest commits?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#57 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAxAyHhwHZ2c55Lac5HXDoPv_fsYplYgks5tNjfagaJpZM4RnfVD>
.
|
|
I ticked "allow edits from maintainers" - assume that's what you are referring to. It's really a minor contribution - but happy to have my feet wet - hopefully I can contribute more meaningfully in the future! Rock on! |
test/mining.js
Outdated
| if (err) return reject(err); | ||
| accept(); | ||
| if(result.result !== '0x0') return reject(new Error("evm_mine should return result = '0x0':" + JSON.stringify(result))) |
There was a problem hiding this comment.
This works fine, but it's more idiomatic to write assert.notDeepEqual(result.result, '0x0')
There was a problem hiding this comment.
No need to resubmit - I'll change it when I merge
|
Looks like the test failure was an unrelated test timing out, which seems to happen on the node lte/boron release from time to time. I'm rerunning that build and provided it doesn't fail a second time around, I'll merge. |
benjamincburns
force-pushed
the
develop
branch
from
9a691a0
to
372f3c2
Compare
|
rebased changes on current develop and pushed back to upstream repo prior to merging |
|
Testing snob protip: when one corrects a contributor's nonidiomatic assertion logic, one looks rather foolish when the "correction" breaks the contributor's test. 😂 Fixed ;-) |
evm_mine returns true in the result to ensure valid JSON_RPC response.