Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Enhancement: Enable expedient solc-js parsing when using docker or native solc #2067

Merged
merged 27 commits into from
Jul 11, 2019

Conversation

CruzMolina
Copy link
Contributor

Continuation of #2007 building on the efforts of #2042.

Context:
Removing solc-js from Parser.parseImports significantly slowed docker compilations.

Solution:
This PR enables leveraging the default cached soljson (currently solc 0.5.8) specifically for speedy import parsing when using docker or native solc. Primary contract compilation is still handled by whatever the user is specifying.

To enable speedy JS parsing, users will need to specify a parser: "solcjs" key/value pair in their config like so:

module.exports = {
  compilers: {
    solc: {
      parser: "solcjs"
    }
  }  
}

@coveralls
Copy link

coveralls commented Jun 1, 2019

Coverage Status

Coverage decreased (-0.02%) to 70.372% when pulling 512a5fb on enableJSparsing into 238c5c0 on develop.

@CruzMolina CruzMolina changed the base branch from develop to compile-output-array June 7, 2019 21:04
@CruzMolina CruzMolina force-pushed the enableJSparsing branch 8 times, most recently from d57f0df to 5e7e591 Compare June 11, 2019 16:36
@CruzMolina
Copy link
Contributor Author

Wow, thanks for that long detour Travis.

@gnidan, I think this is finally ready.

@gnidan gnidan force-pushed the compile-output-array branch 4 times, most recently from eadb547 to 237e87e Compare June 24, 2019 23:41
@gnidan gnidan force-pushed the compile-output-array branch 3 times, most recently from cf8e2a8 to bde0a9e Compare June 28, 2019 22:36
@BrendanChou
Copy link

Any plans to merge this?

@gnidan
Copy link
Contributor

gnidan commented Jul 4, 2019

Ah thanks for the ping @BrendanChou. I think this was left in a waiting state while #2109 was in flight, but this might be good now? @CruzMolina this can be reviewed/merged pending the conflicts, right?

@CruzMolina CruzMolina changed the base branch from compile-output-array to develop July 5, 2019 15:06
Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this released!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants