This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Enhancement: Enable expedient solc-js parsing when using docker or native solc #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… setSolcParser (profiler.js)
…eturn parserSolc (compilerSupplier/index.js)
…ports (profiler.js)
CruzMolina
force-pushed
the
enableJSparsing
branch
8 times, most recently
from
June 11, 2019 16:36
d57f0df
to
5e7e591
Compare
Wow, thanks for that long detour Travis. @gnidan, I think this is finally ready. |
gnidan
force-pushed
the
compile-output-array
branch
from
June 15, 2019 01:59
0a8fd3d
to
cbeac7a
Compare
gnidan
force-pushed
the
compile-output-array
branch
4 times, most recently
from
June 24, 2019 23:41
eadb547
to
237e87e
Compare
gnidan
force-pushed
the
compile-output-array
branch
3 times, most recently
from
June 28, 2019 22:36
cf8e2a8
to
bde0a9e
Compare
Any plans to merge this? |
Ah thanks for the ping @BrendanChou. I think this was left in a waiting state while #2109 was in flight, but this might be good now? @CruzMolina this can be reviewed/merged pending the conflicts, right? |
CruzMolina
force-pushed
the
enableJSparsing
branch
from
July 5, 2019 17:24
143da65
to
b20aa56
Compare
…o enableJSparsing
CruzMolina
force-pushed
the
enableJSparsing
branch
from
July 5, 2019 18:11
b20aa56
to
853c17f
Compare
gnidan
approved these changes
Jul 11, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this released!
1 task
This was referenced Dec 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2007 building on the efforts of #2042.
Context:
Removing
solc-js
fromParser.parseImports
significantly slowed docker compilations.Solution:
This PR enables leveraging the default cached soljson (currently solc 0.5.8) specifically for speedy import parsing when using docker or native solc. Primary contract compilation is still handled by whatever the user is specifying.
To enable speedy JS parsing, users will need to specify a
parser: "solcjs"
key/value pair in their config like so: