This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Generate truffle library webpack bundle for package main #2226
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2222
Makes the following possible (in a plugin context, for example).
Implementation Details
In Plugin improvement: expose truffle-core's index.js in webpack bundle #2222 I proposed using webpack expose-loader for this because I was concerned about the bundle size growing a lot. The unpacked version is bigger here (25-30%), but the packed version sent over the wire from npm is still quite small and it doesn't affect installation speeds. I published my own version to test that issue & validate the POC in the code snippet above - everything worked. Also expose-loader is a nightmare.
Added
ganache-core
to thetruffle-core
exports so consumer can spin up an in-process provider.Added top layer API correctness tests - you'll get a scenario test failure if you delete/rename one of those methods.
cf: solidity-coverage 0.7.0