Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

allow extractOptions to work with -option #5443

Merged
merged 1 commit into from
Aug 16, 2022
Merged

Conversation

lsqproduction
Copy link
Contributor

extractOption at the current state only recognized --options, this adds -option.

Copy link
Contributor

@haltman-at haltman-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's probably worth noting just what this affects. As best I can tell, this only affects whether a given option triggers the unsupported options warning, right?

@lsqproduction
Copy link
Contributor Author

you're correct @haltman-at. Do you think this should be noted in the comments in the code?

@eggplantzzz
Copy link
Contributor

eggplantzzz commented Aug 16, 2022

I don't think that should be mentioned in comments in the code. The method name is clear enough to describe what it does and if you come across usage you will be able to see what is going on. It is just helpful to understand context while reviewing the PR. Thanks @lsqproduction!

@haltman-at
Copy link
Contributor

Yes agree with Tyler, this doesn't need a code comment, would have been helpful to note in the PR though.

@lsqproduction
Copy link
Contributor Author

lsqproduction commented Aug 16, 2022

gotcha. Thank you for explaining. Noted for the future 😄

@lsqproduction lsqproduction merged commit 4a07164 into develop Aug 16, 2022
@lsqproduction lsqproduction deleted the extractOptions branch August 16, 2022 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants