Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

[internal improvement] from-hardhat: use jest to skip tests #5590

Merged
merged 1 commit into from
Oct 5, 2022

Conversation

cds-amal
Copy link
Member

@cds-amal cds-amal commented Oct 5, 2022

This PR fixes an issue on OS X which caused @truffle/from-hardhat to error during yarn test

Error

$ $(yarn bin)/lerna run test --stream --concurrency=1 --scope @truffle/from-hardhat -- --colors
lerna notice cli v4.0.0
lerna info versioning independent
lerna notice filter including "@truffle/from-hardhat"
lerna info filter [ '@truffle/from-hardhat' ]
lerna info Executing command in 1 package: "yarn run test --colors"
yarn run v1.22.19
$ exit 0 --colors
@truffle/from-hardhat: /bin/sh: line 0: exit: too many arguments
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
lerna ERR! yarn run test --colors exited 1 in '@truffle/from-hardhat'

With fix

$ $(yarn bin)/lerna run test --stream --concurrency=1 --scope @truffle/from-hardhat -- --colors
lerna notice cli v4.0.0
lerna info versioning independent
lerna notice filter including "@truffle/from-hardhat"
lerna info filter [ '@truffle/from-hardhat' ]
lerna info Executing command in 1 package: "yarn run test --colors"
yarn run v1.22.19
$ jest --passWithNoTests --colors
@truffle/from-hardhat: No tests found, exiting with code 0
Done in 0.66s.
lerna success run Ran npm script 'test' in 1 package in 0.7s:
lerna success - @truffle/from-hardhat

@cds-amal cds-amal changed the title internal improvement: from-hardhat: use jest to skip tests [internal improvement] from-hardhat: use jest to skip tests Oct 5, 2022
@lsqproduction
Copy link
Contributor

Neat. Do we change it out when tests do get written into this package?

@cds-amal cds-amal merged commit 9603287 into develop Oct 5, 2022
@cds-amal cds-amal deleted the test/unclad branch October 5, 2022 16:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants