Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

migrate migrate to TS #5599

Merged
merged 1 commit into from
Oct 7, 2022
Merged

migrate migrate to TS #5599

merged 1 commit into from
Oct 7, 2022

Conversation

eggplantzzz
Copy link
Contributor

revert commit 9137843

cliffoo
cliffoo approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@cliffoo cliffoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for some reference:
OG PR: #5481
But then #5600 came up
So Revert PR: #5593
But #5600 was actually always there, OG PR simply discovered it, hence:
Revert Revert PR: This one.
#5600 will be addressed separately.

Thanks @eggplantzzz !

@eggplantzzz eggplantzzz merged commit 15dae6f into develop Oct 7, 2022
@eggplantzzz eggplantzzz deleted the migrate-ts3 branch October 7, 2022 19:16
@eggplantzzz eggplantzzz mentioned this pull request Oct 10, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cliffoo cliffoo cliffoo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eggplantzzz @cliffoo