This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
delete dependabot.yml #5604
Closed
delete dependabot.yml #5604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existence of this file with this configuration disables all security updates. See: dependabot/dependabot-core#5845
cds-amal
reviewed
Oct 10, 2022
Comment on lines
-18
to
-20
| # Disable version updates for npm dependencies | ||
| # see https://docs.github.com/en/code-security/dependabot/dependabot-security-updates/configuring-dependabot-security-updates#overriding-the-default-behavior-with-a-configuration-file | ||
| open-pull-requests-limit: 0 |
There was a problem hiding this comment.
@davidmurdoch what happens if this setting is removed?
There was a problem hiding this comment.
The problem with the current config is that github doesn't allow us to specify npm twice. You are looking at the 2nd of 2 npm configs. This open-pull-requests-limit: 0 setting is the official documented hack way to enable security-only updates; setting open-pull-requests-limit actually sets it to 10 if the Security Updates setting is enabled in the GitHub UI.
|
This is no longer necessary, right? |
Have we confirmed that hack from the other PR has re-enabled dependabot? |
|
Yup! I've been running it to find dependencies to update and even made one update on that basis (#5613). :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existence of this file with this configuration disables all security updates. See: dependabot/dependabot-core#5845