This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Silence Lerna's cycle dependency warnings #5612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporarily disable the lerna cycles warning.
cds-amal
changed the title
cliffoo
approved these changes
Oct 12, 2022
| @@ -6,7 +6,7 @@ import gql from "graphql-tag"; | |||
| import { connect } from "@truffle/db"; | |||
| import { ArtifactsLoader } from "./artifacts"; | |||
| import { generateId } from "@truffle/db/system"; | |||
| import Migrate from "@truffle/migrate"; | |||
There was a problem hiding this comment.
CommonJS import to make get past compile and test
This fails with import?
eggplantzzz
approved these changes
Oct 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
@truffle/db's devDep on@truffle/migrateto get rid of lerna's cycle dep error.Note: uses CommonJS import to make get past compile and test.
This dependency exists only for a single integration test in truffle-db, and we feel it's better to not impact Lerna's dependency/ordering until we remove the circular dependency in the near future.