This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Internal improvement: return cleanup callback from sandbox test utility and update tests #5641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eggplantzzz
force-pushed
the
update-sandbox
branch
from
73dceae
to
61bde85
Compare
cds-amal
reviewed
Oct 25, 2022
eggplantzzz
force-pushed
the
update-sandbox
branch
5 times, most recently
from
a102e04
to
9d8602d
Compare
eggplantzzz
force-pushed
the
update-sandbox
branch
from
d671183
to
38d8573
Compare
eggplantzzz
force-pushed
the
update-sandbox
branch
from
38d8573
to
4ab767e
Compare
dongmingh
approved these changes
Nov 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While performing some testing locally I noticed that some of the temporary test project files were getting left on my computer and not deleted. tmp is supposed to clean up after itself but perhaps in some cases, say when an error is thrown, it doesn't. In order to try and tidy things up, this PR returns the manual cleanup callback from tmp from the sandbox utility. It then adds the call to the cleanup function in all tests that utilize the sandbox utility.