Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

Remove invalid networks check from Sourcify fetcher #6171

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Conversation

haltman-at
Copy link
Contributor

As described!

Copy link
Contributor

@gnidan gnidan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we want to deal with the list of networks possibly becoming out of date?

@haltman-at
Copy link
Contributor Author

Well, as mentioned, we'll no longer be checking it, so the list will only even be relevant if you explicitly ask for supported networks. As for how we stop that from going out of date, outside of constant manual updating... well, there are potential ways if, like, we import sourcify as a dependency? I think we don't want to do that though.

@gnidan
Copy link
Contributor

gnidan commented Aug 25, 2023

As for how we stop that from going out of date, outside of constant manual updating... well, there are potential ways if, like, we import sourcify as a dependency? I think we don't want to do that though.

Moreso I'm asking about how to ensure users are aware that this list may not be up-to-date

@haltman-at
Copy link
Contributor Author

Oh, yeah, I have no ideas for that offhand.

@haltman-at
Copy link
Contributor Author

OK, I added a note to the README per @gnidan's suggestion elsewhere.

@haltman-at haltman-at merged commit 3a7b057 into develop Aug 28, 2023
10 checks passed
@haltman-at haltman-at deleted the open-ended branch August 28, 2023 17:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants