-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Conversation
Hm, do we want to set |
How about pinning to lts as of now, I guess it's mostly a matter of if you want future upgrades to be explicit or not. |
Oh, well right now we're still supporting 16, so...? |
@haltman-at Note that the value in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approach is probably what we should've been doing all along.
For that .nvmrc
, I think we probably would want that yarncheck
job to run on the earliest Node version we support, but it probably doesn't matter too much.
One approve from me :) Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, if Nick says it's good, then I'm also OK with it!
PR description
engines.node
to indicate supported Node.js version range.nvmrc
set tolts/*
yarncheck
job from.nvmrc
instead of using harcoded vesionTesting instructions
Documentation
doc-change-required
label to this PR if documentation updates are required.Breaking changes and new features
breaking-change
andnew-feature
labels for the appropriate packages.