This repository has been archived by the owner on Mar 11, 2024. It is now read-only.
Invalidate require cache of truffle-config.js
#265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xhulz
approved these changes
Nov 23, 2022
| try { | ||
| const originalRequire = eval('require'); | ||
| // Mimics the behavior of `Config.detect` until https://github.com/trufflesuite/truffle/pull/5728 gets merged. | ||
| const file = path.join(args.workingDirectory, 'truffle-config.js'); |
There was a problem hiding this comment.
Would it be a problem if we have the truffle config file with another name?
There was a problem hiding this comment.
Yes, it will be an issue, but it's not currently supported. The Config.detect method expects the same name. This is related to #256.
There was a problem hiding this comment.
Yeah, you're right :)
Thank you @acuarica!
|
Hey @acuarica, following our discussion on this I've just done a full smoke test and all looking good 👍 |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
This PR closes #262. Essentially duplicates the changes made in trufflesuite/truffle#5728. This means that if trufflesuite/truffle#5728 gets merged we can revert the changes of this PR.
Documentation
doc-change-requiredlabel to this PR if documentation updates are required.