JS Remove Comments setting is missing

[PrzemyslawKlys]

There is a setting called RemoveComments for HTML, but for CSS/JS those are missing. Maybe it should be an option for those.

Although this brings special kinds of problems like it does for VSCode where it's not able to format this properly.

            h6 {
                font-family: 'Hammersmith One', sans-serif;
                /*
    font-family: 'Questrial', sans-serif;
    */
            }

[trullock]

Because the current default functionality is to always remove them, right?

And you want the option to keep them?

[PrzemyslawKlys]

Well, it's always removing it for CSS and JS, yet you give an option to keep HTML comments. Seems reasonable to me to have the option to keep them for JS and CSS as well. Not that I need them, just think for consistency's sake. Sometimes I do include some stuff that may have meaning to debug things, that may otherwise be removed.

[trullock]

For CSS you can use CssSettings.CommentMode, but for JS theres only the option to keep important comments

[PrzemyslawKlys]

I see, couldn't find that :-) What's an important comment?

[trullock]

Comments that start with //! or /*!, you usually see them at the top of libs with the license info in it

Not an official syntax but commonly adopted

[trullock]

This has uncovered a bug whereby prologue directives are broken by there being preceeding important comments in the block.

This needs fixing, might as well be along with this ticket as this ticket will otherwise only reintroduce the same issue with non-important comments

[trullock]

Added a PR for this, please have a play and see if this meets your needs

[PrzemyslawKlys]

Just came back to this seeing as the PR hasn't been merged yet. Is there anything you want me to check, confirm?

[trullock]

Yeah, can you test the PR meets your needs?

[PrzemyslawKlys]

This has uncovered a bug whereby prologue directives are broken by there being preceding important comments in the block.

This needs fixing, might as well be along with this ticket as this ticket will otherwise only reintroduce the same issue with non-important comments

I thought the PR is to fix unrelated issues no?

[trullock]

It fixes both, i hope!