Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow actionlint to run shellcheck on run blocks #481

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

det
Copy link
Contributor

@det det commented Sep 19, 2023

actionlint will run shellcheck on run blocks as long as it is in path.

@trunk-io
Copy link

trunk-io bot commented Sep 19, 2023

⏱️ 27m total CI duration on this PR
Job Total Duration Recent Runs
Linter Tests (macos-latest) 8m 🟥🟩
CodeQL-Build 6m 🟩🟩🟩
Linter Tests (ubuntu-latest) 5m 🟥🟩🟩
Windows Linter Tests 5m 🟥🟥🟥
Repo Tests / Plugin Tests 2m 🟩🟩🟩
Detect changed files 22s 🟩🟩🟩
Aggregate Test Results 6s 🟥🟥🟥🟩

🚨 2 jobs on the last run were significantly faster/slower than expected

Job Duration vs 7d avg Delta
Windows Linter Tests 2m 3m -42%
Linter Tests (macos-latest) 3m 34m -92%

settingsfeedbackdocs ⋅ learn more about trunk.io

@det det requested a review from laurit17 September 19, 2023 20:44
Copy link
Contributor

@laurit17 laurit17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woo!

@TylerJang27 TylerJang27 marked this pull request as draft September 19, 2023 21:50
@TylerJang27
Copy link
Collaborator

TylerJang27 added a commit that referenced this pull request Sep 22, 2023
Both released new versions. Notably the formatting result for
remark-lint changed, but it seems fine enough.

Note that this will introduce conflicts with #481, but that won't be
able to land/release until the relevant CLI changes have released.
@EliSchleifer
Copy link
Member

@det - Is this landable now? Looks like blockers have landed

@det
Copy link
Contributor Author

det commented Oct 13, 2023

@det - Is this landable now? Looks like blockers have landed

Needs 1.17.0 which is releasing now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants