Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure trunk knows when checkov fails #592

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Ensure trunk knows when checkov fails #592

merged 3 commits into from
Dec 19, 2023

Conversation

det
Copy link
Contributor

@det det commented Dec 15, 2023

Python will exit 1 when printing a backtrace from a crash so we want trunk to know that is a failure.
Tell checkov to always exit 0, even when there are issues, so we can rely on that.

Copy link

trunk-io bot commented Dec 15, 2023

⏱️ 21m total CI duration on this PR
Job Cumulative Duration Recent Runs
Linter Tests macOS 6m 🟩
Windows Linter Tests 5m 🟩
Linter Tests Linux 3m 🟩
CodeQL-Build 2m 🟩
Tool Tests (macOS) 1m 🟩
Tool Tests (Linux) 1m 🟩
Trunk Check runner [linux] 1m 🟩
Repo Tests / Plugin Tests 27s 🟩
Detect changed files 8s 🟩
Aggregate Test Results 3s 🟩

settingsfeedbackdocs ⋅ learn more about trunk.io

Copy link
Contributor

@pat-trunk-io pat-trunk-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TylerJang27 TylerJang27 changed the title Ensure trunk knows when chevkov fails Ensure trunk knows when checkov fails Dec 18, 2023
@det det merged commit 2f29479 into main Dec 19, 2023
14 checks passed
@det det deleted the det/checkov_fix branch December 19, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants