Fix deprecation warning for wasm-bindgen >= 0.2.93 #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctron
requested changes
Nov 6, 2024
src/tools.rs
Outdated
| @@ -253,7 +253,7 @@ pub async fn get( | |||
| version: Option<&str>, | |||
| offline: bool, | |||
| client_options: &HttpClientOptions, | |||
| ) -> Result<PathBuf> { | |||
| ) -> Result<(PathBuf, String)> { | |||
There was a problem hiding this comment.
I am not a fan of having this as a mandatory return value. Maybe we can have a get_details function, which returns a struct (which we can extend later). And then have an implementation of get reusing that new function, dropping everything exception the path.
yescallop
force-pushed
the
fix-deprecation-warning
branch
from
c042c0c
to
7884303
Compare
|
Thanks for the suggestions. I introduced a |
Co-authored-by: Jens Reimann <ctron@dentrassi.de>
ctron
force-pushed
the
fix-deprecation-warning
branch
from
f65407c
to
56f1b02
Compare
ctron
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #905 by passing an object to
initinstead when the version of wasm-bindgen is >= 0.2.93.