Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: confirm config update #29

Merged
merged 3 commits into from
Jan 16, 2023
Merged

feat: confirm config update #29

merged 3 commits into from
Jan 16, 2023

Conversation

mark-omarov
Copy link
Member

Description

  • Added missing dependencies to the lock file.
  • Improved setup environment guide with information on dependency caching.
  • Updated notifying message about CLI being configured with colors.
  • Added a prompt to confirm the intent to update the configuration.

Related Issue

Closes: #26

@mark-omarov mark-omarov added the type: feature New feature or request label Jan 16, 2023
@mark-omarov mark-omarov added this to the v0.1.0 milestone Jan 16, 2023
@mark-omarov mark-omarov self-assigned this Jan 16, 2023
@mark-omarov mark-omarov changed the title feat: config notification feat: confirm config update Jan 16, 2023
@mark-omarov mark-omarov marked this pull request as ready for review January 16, 2023 13:29
@mark-omarov mark-omarov requested a review from a team as a code owner January 16, 2023 13:29
alexey-marinkevich
alexey-marinkevich approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@alexey-marinkevich alexey-marinkevich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is much easier to read, I like it

@alexey-marinkevich alexey-marinkevich merged commit b677f10 into main Jan 16, 2023
@alexey-marinkevich alexey-marinkevich deleted the feat/config-notification branch January 16, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexey-marinkevich alexey-marinkevich alexey-marinkevich approved these changes

Assignees

@mark-omarov mark-omarov

Labels
type: feature New feature or request
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

[FEAT] Notification when config exists
2 participants
@mark-omarov @alexey-marinkevich