Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: memoize getRepository responses #52

Merged
merged 3 commits into from
Feb 25, 2023
Merged

Conversation

mark-omarov
Copy link
Member

close #45

I've also dropped jq command usage and replaced it with JSON.parse for now. Not everyone have jq installed (as it happened I didn't have one on my new machine), so it's probably for the best. We might need to come back and improve this part later, but as long as GitHub responds with JSON there should be no problem.

@mark-omarov mark-omarov added the type: refactor Improvements over code label Feb 22, 2023
@mark-omarov mark-omarov self-assigned this Feb 22, 2023
@mark-omarov mark-omarov requested a review from a team as a code owner February 22, 2023 10:03
@mark-omarov mark-omarov merged commit 022ea4a into main Feb 25, 2023
@mark-omarov mark-omarov deleted the refactor/memoization branch February 25, 2023 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: refactor Improvements over code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🔨 replace custom caching with memoization
1 participant