Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for https://github.com/trusche/httplog/pull/107 #111

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Fix for https://github.com/trusche/httplog/pull/107 #111

merged 1 commit into from
Jun 30, 2021

Conversation

Meat-Chopper
Copy link
Contributor

No description provided.

@Meat-Chopper Meat-Chopper mentioned this pull request Jun 30, 2021
Merged
@trusche trusche merged commit 9f6e8a7 into trusche:master Jun 30, 2021
@Meat-Chopper
Copy link
Contributor Author

The fix is useless after this change https://github.com/trusche/httplog/pull/110/files#diff-1b3dd928100114cd5b73ffbd83ad4750c2951016da53c62484ffd8d3bb00b04e

@tycooon
Copy link
Contributor

tycooon commented Jul 2, 2021

@trusche I'm not sure how this should work. I see that module Rainbow is used directly in the gem. And by the way, I already returned rainbow to gem runtime dependencies in e42e308.

@tycooon
Copy link
Contributor

tycooon commented Jul 2, 2021

So this probably can be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Meat-Chopper @tycooon @trusche