Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not showing binary request data by Content-Type for httpclient adapter #53

Closed
wants to merge 2 commits into from
Closed

Not showing binary request data by Content-Type for httpclient adapter #53

wants to merge 2 commits into from

Conversation

Qwertyn
Copy link

@Qwertyn Qwertyn commented Dec 2, 2017

No description provided.

trusche
trusche requested changes Dec 3, 2017
View reviewed changes
Copy link
Owner

@trusche trusche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, but it's breaking a bunch of tests, and also introduces differences between httpclient and the other adapters. I'll happily accept this if it's consistent across all adapters and comes with a new test for the new behaviour.

lib/httplog/http_log.rb
return if config.compact_log || !config.log_data
unless text_based?(content_type)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is breaking all other adapters, since they're not passing in the request content type, and the default nil will not be treated as text based.

@Qwertyn
Copy link
Author

Qwertyn commented Dec 4, 2017

Fix test for ethon, excon, http, patron adapters.
There were difficulties with the adapter Net::HTTP.
help me please...

@trusche
Copy link
Owner

trusche commented Dec 6, 2017

Cheers. It looks like Net::HTTP passes the content type differently to post requests (with a symbol :content_type as the hash key). I'll try to resolve it, but I'm a bit short on time these days, so it may take a bit.

@trusche trusche closed this Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trusche trusche trusche requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qwertyn @trusche